Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate google_compute_firewall_policy_association resource from DCL to MMv1 #12466

Merged
merged 11 commits into from
Dec 18, 2024
Merged

Migrate google_compute_firewall_policy_association resource from DCL to MMv1 #12466

merged 11 commits into from
Dec 18, 2024
+184 −115

Conversation

Samir-Cit
Copy link
Contributor

Hello folks.
This PR is to move the Firewall Policy Association (google_compute_firewall_policy_association) resource from DCL to MMv1. And this PR includes:

  • Creation of the resource on MMv1.
  • Creation of the examples and tests.
  • Remove references to DCL resource.

Note: This PR doesn't include the deletion of the DCL resource. This change will be done on the Delarative Resource Client Library repository.

Release Note Template for Downstream PRs (will be copied)

compute: `google_compute_firewall_policy_association` now uses MMv1 engine instead of DCL.

@github-actions github-actions bot requested a review from BBBmau December 2, 2024 14:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/network-security-distributed-firewall and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Dec 2, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 86 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 6 files changed, 279 insertions(+), 135 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 94 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1070
Passed tests: 996
Skipped tests: 73
Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFirewallPolicyAssociation_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeFirewallPolicyAssociation_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions GitHub Actions
Copy link

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Dec 18, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 277 insertions(+), 135 deletions(-))
google-beta provider: Diff ( 6 files changed, 277 insertions(+), 135 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 94 insertions(+))

BBBmau
BBBmau approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving after testing through TeamCity Infra

image

@BBBmau BBBmau merged commit 613bdae into GoogleCloudPlatform:main Dec 18, 2024
15 of 16 checks passed
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1077
Passed tests: 1004
Skipped tests: 73
Affected tests: 0

Click here to see the affected service packages
  • compute

🟢 All tests passed!

View the build log

This was referenced Dec 18, 2024
Merged
Merged
@modular-magician modular-magician mentioned this pull request Dec 18, 2024
Merged
@melinath melinath mentioned this pull request Dec 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BBBmau BBBmau BBBmau approved these changes

Assignees
No one assigned
Labels
service/network-security-distributed-firewall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Samir-Cit @modular-magician @BBBmau @zli82016